Skip to content

updated partial sums builder handle_named_function and handle_sum to …#619

Open
natalieb-noaa wants to merge 2 commits intomainfrom
613-update-partial-sums-handler-to-accept-param-object-that-contains-both-model-and-obs-var-names
Open

updated partial sums builder handle_named_function and handle_sum to …#619
natalieb-noaa wants to merge 2 commits intomainfrom
613-update-partial-sums-handler-to-accept-param-object-that-contains-both-model-and-obs-var-names

Conversation

@natalieb-noaa
Copy link
Copy Markdown
Contributor

…accomodate dict-like parameter for different obs and model variable names. added unit tests for handle_sum that test both param types.

…accomodate dict-like parameter for different obs and model variable names. added unit tests for handle_sum that test both param types.
@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
vxingest 31% 22%
vxingest.builder_common 23% 11%
vxingest.ctc_to_cb 11% 1%
vxingest.grib2_to_cb 21% 6%
vxingest.netcdf_to_cb 22% 13%
vxingest.partial_sums_to_cb 22% 8%
vxingest.prepbufr_to_cb 100% 100%
vxingest.utilities 30% 35%
Summary 21% (772 / 3642) 10% (94 / 918)

Copy link
Copy Markdown
Collaborator

@randytpierce randytpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite nice. I'll merge the integration test branch into this, make sure all the tests work, including the partial sums one and then merge to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update partial sums handler to accept param object that contains both model and obs var names

2 participants