Merged
Conversation
maddenp-cu
commented
Mar 26, 2026
Comment on lines
+231
to
+233
| # Scalar: quoted with no whitespace. | ||
| case MET.model: | ||
| return _kvpair(k, _quoted(v.replace(" ", "_")), level) |
Collaborator
Author
There was a problem hiding this comment.
MET doesn't allow whitespace in the model name, which is too bad because then the ugly name with an underscore shows up in the plot legend, but it might be tricky to change, because sometimes you might really have an underscore in a name and wouldn't want it converted to a space.
elcarpenterNOAA
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some testing today, I ran into three novel issues:
forecast.pathto just the GRIB filename,gfs.t00z.pgrb2.0p25.f024. When this value was written to the METgrid_statconfig as the input path, though,grid_statfailed because that file was not in its run directory. This PR adds some.resolve()calls onPathobjects to turn potentially relative paths into absolute paths, which are then valid in e.g. agrid_statrun directory.forecast.namewith spaces, which I noticed when I tried to call my forecast datasetGFS Forecast(because mytruth.namewas set toGFSand I needed a different value forforecast.name). This PR adds support for that, by replacing spaces with underscores where required in filenames and in MET config files.wxvxconfig required thatpaths.grids.forecastbe set, but this path isn't used when the forecast dataset is local GRIB: MET is directed to just read the original GRIB file, so no grid files are extracted from it, and so no directory is needed to store them. So the schema and docs are updated here. Note that there was already post-schema validation logic in place to deal with a missing value when it is actually needed, i.e. when the forecast dataset is not GRIB:GDAS, which is identical toGFS(at least I think so -- real world testing will follow soon) except in name. GDAS is the Global Data Assimilation System, and its output is used to initialize the GFS.