Open
Conversation
andywood
approved these changes
Aug 6, 2024
Contributor
andywood
left a comment
andywood
left a comment
There was a problem hiding this comment.
These changes look fine and correct the declaration/assignment issue with the previous coding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some variables are initialized when they are declared. Depending on the compiler, these variables may not be properly initialized on subsequent invocations.
Additions
Initialized variables in the subroutine body. Changed variables to parameters if they do not change.
Removals
Removed variable initializations from the lines that declares them.
Testing
Screenshots
Notes
Changes based on notes in Issue #44