-
Notifications
You must be signed in to change notification settings - Fork 6
New models #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johanlundberg
wants to merge
47
commits into
NORDUnet:master
Choose a base branch
from
SUNET:merge_upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New models #18
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
df45e29
New models and methods
4b8db77
New relations cased according to the rest of the project.
b063698
Name change for relations between contact and organization and small …
501bf69
New methods, nodes and relationships added to the test suite.
1b63629
Parent relationship bugfix
2fce4cf
Merge pull request #2 from PaKZer0/newmodels
PaKZer0 5228e9b
Defects detected on PR fixed
a38610a
Updated .travis.yml and added jenkins.yaml
johanlundberg 6cf9ab3
Install wheel
johanlundberg 87e61dd
New ContactModel method
99ad93c
'Has' relationship removed from query
ed8d0a7
Dict merge simplified.
9acc960
Merge pull request #2 from PaKZer0/master
johanlundberg d94620a
New method: add child organization
0325300
New method to get all the outgoing relations for Contacts
ee384cc
Added tests for some of the new methods.
b61891d
Merge pull request #3 from PaKZer0/master
johanlundberg 6eff922
New methods: one for group and one for organization
abb0297
New tests for the new methods
283637a
Merge pull request #4 from PaKZer0/master
johanlundberg cdb7942
Merge pull request #3 from SUNET/master
PaKZer0 18bcc7c
New organization methods
020561b
Merge pull request #5 from PaKZer0/master
johanlundberg 12903d8
Implementing methods RoleRelationship
3f882a6
Removed old methods and tests changed accordingly
a5c4889
Added load_from_nodes
ebb990f
Return distinct nodes
8eb2225
db manager as param in static methods and list roles testing
5a1ef56
Merge branch 'master' of https://github.com/SUNET/python-norduniclien…
fb359f3
Merge pull request #6 from SUNET/rolefix
johanlundberg f0f729c
New methods for roles, organizations and contacts
983dc9c
Merge pull request #7 from SUNET/rolefix
johanlundberg 5848a98
Method to get all the persons with a determined rolename
64313c9
Merge pull request #8 from SUNET/rolefix
johanlundberg 6619be3
Just a simple name change
f3122b4
Merge pull request #9 from SUNET/quickfix
johanlundberg 68f50cb
Added organization to the result set
aa47996
Change in link method, now the handle_id is required
75890dc
New helper function
4aa8b13
RoleRelation: handle_id init, two methods for contact or role and delete
23ed9a2
Role: Added specific method to get a contact with a role
d90adb2
Deleted outdated methods, some renamed, the new ones added to the tests
b17ebf8
The role id lookup has been reverted to a name lookup in all methods
fcf2e69
Merge pull request #10 from SUNET/orgsandcntct
johanlundberg 3b6b25c
Merge branch 'master' of https://github.com/NORDUnet/python-nordunicl…
johanlundberg 6d3c9f4
Relationships returned are now Relationship objects not dicts
johanlundberg 29b7aed
Remove SUNET specific files
johanlundberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters a lot (and our code is probably full of these things all over the place), but this is not injection safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think setting properties ever was injection safe (and I think you are correct that the problem can be found elsewhere to).