Add chip scanner #18
Add chip scanner #18
Conversation
| y = Cpt(MotorWithEncoder, 'XF:17IDC-ES:FMX{Chip:1-Ax:CY}Mtr') | ||
| z = Cpt(MotorWithEncoder, 'XF:17IDC-ES:FMX{Gon:2-Ax:Z}Mtr') | ||
|
|
||
| def __init__(self, F0_x, F0_y, F1_x, F1_y, F2_x, F2_y, |
There was a problem hiding this comment.
can this be documented? looks like the knowledge about what those parameters are could be very easily lost
There was a problem hiding this comment.
Very good point, we've got a document that this corresponds to, but I should put in a docstring here as well. Is there a good spot you can think of for the doc? We don't want it in this folder, but I could add another one at the top level and include it there.
| epics.caput("XF:17IDC-ES:FMX{Zeb:3}:M1:SETPOS.PROC", 1) | ||
|
|
||
|
|
||
| class ppmac_input(Device): |
There was a problem hiding this comment.
any reason why the class name is not capitalized? would be more consistent
There was a problem hiding this comment.
General incompetence of whatever fool wrote this :P I'll fix that up.
| epics.caput("XF:17IDC-ES:FMX{Zeb:3}:M1:SETPOS.PROC", 1) | ||
|
|
||
|
|
||
| class ppmac_input(Device): |
There was a problem hiding this comment.
can you refer to the ppmac programs that are to be called in some way? this would be useful for the future when trying to recreate the system on another machine/beamline
There was a problem hiding this comment.
Maybe... I'll have to give some thought as to how to do this, but it's a good idea to keep this as general as possible.
@mfuchsbnl @JunAishima FYI