Skip to content

Commit

Permalink
Specify suggestions Uid
Browse files Browse the repository at this point in the history
  • Loading branch information
maffettone committed Nov 7, 2022
1 parent 4ff356d commit 3459e3c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions docs/source/agent-communication.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ name, doc = [
# name of agent, used by adjudicator
"agent": "aardvark",
# unique ID of this ask / batch of suggestions
"uid": "086ff562-c997-48c7-9fbb-9cbe3c362ff0",
"suggestions_uid": "086ff562-c997-48c7-9fbb-9cbe3c362ff0",
# per-beamline suggestions
"suggestions": {
"pdf": [
Expand Down Expand Up @@ -112,11 +112,11 @@ name, doc = [
The outer and inner layers may contain additional information, all keys in
`"suggestions"` are assumed to be beamline TLAs.

The outer `publish_id` is a unique id for the ask from the agent. The
The outer `suggestions_uid` is a unique id for the ask from the agent. The
per-suggestion aids are so that the adjudicator can track if it has added that
particular suggestion to the queue before.

All of `"agent_name"`, `"publish_uid"`, and `"suggestion_uid"` should be added
All of `"agent_name"`, `"ask_uid"`, and `"suggestions_uid"` should be added
to the metadata when the plan is added to the queue by the adjudicator.


Expand Down
2 changes: 1 addition & 1 deletion mmm_experiments/adjudicators/msg.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Suggestion(BaseModel):

class AdjudicatorMsg(BaseModel):
agent_name: str
uid: str
suggestions_uid: str
suggestions: dict[str, list[Suggestion]] # TLA: list


Expand Down

0 comments on commit 3459e3c

Please sign in to comment.