Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding torch.tensor(np.nan) bug fix #77

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jennmald
Copy link
Contributor

@jennmald jennmald commented Nov 18, 2024

Adds the fix for torch.tensor(np.nan) for #76 in agent.py
Still needs test case for this fix using Ophyd sim and the updated doc string to explain the enforce_all_objectives_valid parameter.

Closes #76

@jennmald jennmald marked this pull request as draft November 18, 2024 15:14
@jennmald
Copy link
Contributor Author

@mrakitin @yxrmz I made the fix for the open issue but am having trouble coming up with a test case still using Ophyd sim. Let me know if either of you have ideas. thanks!

@mrakitin
Copy link
Member

@thomaswmorris, could you please help Jennefer with the description of the parameter?

@thomaswmorris
Copy link
Contributor

@jennmald you would turn on enforce_all_objectives_valid if you want to throw away all the beam diagnostics when one of them is bad, e.g. if the flux is invalid because it's too low and so you want to automatically throw away the size estimate. But this isn't always true, e.g. at TES where you can measure the flux separately from the size and so we would still want to fit to the flux even if the size diagnostic is messed up.

@jennmald
Copy link
Contributor Author

Thanks @thomaswmorris !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User report
3 participants