Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update synced with CHX_Software/pyCHX on April 29, 2024 #82

Merged
merged 2 commits into from
May 3, 2024

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Apr 29, 2024

Those changes will be merged after testing at the beamline.
The plan is to:
1) Release the changes "as is" without reformatting (as v4.3.0)
2) Apply black/flake8/isort to the codebase and release as v4.3.1.
As we already have the CI linter, we may need to properly fix the code style before releasing. We'll do it as a second step after testing.

@mrakitin
Copy link
Member Author

Attn @XYangXRay @hyperrealist

@mrakitin
Copy link
Member Author

Diffs are much nicer after applying pre-commit to the code base:
https://github.com/NSLS-II/pyCHX/compare/updates-20240429-with-style-fixes?expand=1

@mrakitin mrakitin merged commit fc45928 into main May 3, 2024
20 of 24 checks passed
@mrakitin mrakitin deleted the updates-20240429 branch May 3, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant