Repository navigation
Move the check and the bot out of the workflow file - #64
Merged
Merged
Conversation
GitHub treats a PR whose branch carries an older copy of a workflow file as one that modifies workflows, and then refuses to let GITHUB_TOKEN merge it — stranding every fork made before the change. That bit #17, #14 and #7 today. Only .github/workflows is restricted, so the logic moves to .github/scripts/ (validate-signature.sh, workbook-bot.js) and the workflow becomes a thin runner. Editing the logic from now on leaves existing forks mergeable. Also folds in #63: on a 403 the bot explains the stale fork and how to sync it, instead of a vague hand-off to the council.
Contributor
|
Hi @geetxnshgoyal 👋 thanks for signing the workbook! The check found a problem:
How to fix it (in your clone, on the same branch as this PR): # fix the file as described above, then:
git add -A
git commit -m "Fix signature"
git pushYour file should look like: # Your Real Name
- **GitHub:** @geetxnshgoyal
- **Batch:** 2026
- **I'm here to:** your own line
- **One thing I've built:** a link, or nothing yetPush to this same PR. Don't open a new one. This comment updates itself each time the check re-runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub treats a PR whose branch carries an older copy of a workflow file as one that modifies workflows, and then refuses to let
GITHUB_TOKENmerge it. Every edit to the workflow therefore strands every fork made before it — that's what blocked #17, #14 and #7 today, and it would happen again on the next edit.Only
.github/workflows/is restricted.What
.github/scripts/validate-signature.sh— the check, unchanged..github/scripts/workbook-bot.js— the comment and the merge, unchanged apart from the folded-in Bot: explain a stale fork instead of silently handing off to the council #63.From now on, changing the logic leaves existing forks mergeable.
Tested
.sh.Needs an admin merge (its own check fails by design). This is the last workflow-file change, so forks made after it stay mergeable.