2025 RPi state machine and player control #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "compress failed" This reverts commit 9cf1ed6.
Revert "compress getCurrentState log" This reverts commit 3cca088.
some problems faced: 1. commands: "play 1 2" plays 1 sec to 2 sec but not 1 ms to 2 ms 2. commands: "play -s 1 2" seems to result playing 1000 sec to 2000 sec 3. commands: "play -d 1000" delay the play 1000 ms 4. play with delay will first light red for a while, and then play after the delay time. the time interval of the red seems to be proportional to the delay time. practically, "play -d 10000" results to about 2 sec of red and "play -d 5000" results to 1 sec. expect some improvement: 1. use "play -ss 1 -to 2" but not "play 1 2"
merge to implement the flag -d with two arguments
complete state machine and player control
|
LGTM. But it would be better if you move the new_rpi.sh into scripts/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update state machine and player control
What type of PR is it?
Improvement
Modification
state machine
player control
The command to player flag processed. Use "-ss " "-to " "-d " to specify the start time, stop time, and the duration of delay as well as the duration of delay display.
scripts
Add the new_rpi script for setting up a new rpi.