[codex] Fix Fern preview metadata upload#2141
Merged
Merged
Conversation
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Contributor
Contributor
chtruong814
approved these changes
Jun 30, 2026
Contributor
Author
|
/ok to test 6906c88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.preview-metadata/producer/consumer contractRoot cause
actions/upload-artifactv4 excludes hidden files by default. The Fern preview build stores the pull request number, head ref, and changed-file list under.preview-metadata/, so the companionworkflow_rundownloaded the Fern sources without that metadata.As a result,
HEAD_REFandPR_NUMBERwere empty: Fern published to the sharedpreview-defaultidentifier and the PR-comment request failed with HTTP 404. This affected draft and ready-for-review pull requests alike.Example failed publisher run: https://github.com/NVIDIA-NeMo/Curator/actions/runs/28404447988
Validation
git diff --checkpassesactions/upload-artifact@v4.6.2step receives its supportedinclude-hidden-filesinputThe PR's own
Preview Fern Docs: Buildand subsequentPreview Fern Docs: Commentruns provide the end-to-end validation.