feat(semdedup): bound pairwise precision and memory - #2318
Draft
praateekmahajan wants to merge 1 commit into
Draft
feat(semdedup): bound pairwise precision and memory#2318praateekmahajan wants to merge 1 commit into
praateekmahajan wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-praateekm-nmcur-318-semdedup-pairwise-precision.docs.buildwithfern.com/nemo/curator Here are the markdown pages you've updated: |
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
| assert stages[1].profile is True | ||
| assert stages[1].verbose is True | ||
|
|
||
| def test_new_options_preserve_existing_positional_order(self) -> None: |
Contributor
Author
There was a problem hiding this comment.
this test is very local, and against what AGENTS.md recommends
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
commented
Aug 17, 2026
praateekmahajan
force-pushed
the
praateekm/nmcur-318-semdedup-pairwise-precision
branch
from
August 18, 2026 00:30
44c3013 to
5586523
Compare
praateekmahajan
commented
Aug 18, 2026
| return None | ||
|
|
||
|
|
||
| def release_cached_gpu_memory() -> None: |
Contributor
Author
There was a problem hiding this comment.
@ayushdg can you review this, to see if it's not sloppy? I'm wondering if we can then also add this in the minhash teardown part
praateekmahajan
commented
Aug 18, 2026
praateekmahajan
commented
Aug 20, 2026
praateekmahajan
commented
Aug 20, 2026
praateekmahajan
commented
Aug 20, 2026
praateekmahajan
commented
Aug 20, 2026
praateekmahajan
force-pushed
the
praateekm/nmcur-318-semdedup-pairwise-precision
branch
2 times, most recently
from
August 21, 2026 01:31
d63a7f3 to
cd18cc1
Compare
Contributor
Author
|
/ok to test cd18cc1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bound Pairwise semantic-dedup memory and add configurable FP16/FP32 compute precision.
Linear: NMCUR-318
Validation