-
Notifications
You must be signed in to change notification settings - Fork 162
feat: make async engine the default execution path #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andreatgretel
merged 15 commits into
main
from
andreatgretel/chore/async-default-prereqs
May 4, 2026
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0a30dbe
feat: make async engine the default execution path
andreatgretel 0328adb
test: extract _compute_bridge_timeout helper for direct testing
andreatgretel 4c9c421
test(e2e): align demo plugins with async engine contracts
andreatgretel 267806d
fix: address Codex review findings on async-default flip
andreatgretel ca6b1fd
Merge remote-tracking branch 'origin/main' into andreatgretel/chore/a…
andreatgretel 17fe64e
test: trim redundant parametrize cases in async-default tests
andreatgretel caf6f2e
docs: fold migration page into existing concept docs
andreatgretel 6181de9
docs: frame Execution Model as sync-engine specifics
andreatgretel bf36d25
fix: address review nits from PR #592 (Nabin)
andreatgretel 7a0b77d
fix: drop SYNC_BRIDGE_TIMEOUT in _run_coroutine_sync
andreatgretel cf0826d
Revert "fix: drop SYNC_BRIDGE_TIMEOUT in _run_coroutine_sync"
andreatgretel 49fc991
Merge branch 'main' into andreatgretel/chore/async-default-prereqs
andreatgretel 43f7113
docs+feat: deprecate the sync-engine opt-out path
andreatgretel 4dfa200
fix: emit logger.warning alongside DeprecationWarning on env-var opt-out
andreatgretel b57d35d
docs: breadcrumb explaining why SYNC_BRIDGE_TIMEOUT survives PR #592
andreatgretel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add "deprecation warning" language here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did both. The doc now uses a
!!! warning "Deprecated"admonition naming the env var as a deprecated escape hatch (43f71130), and the runtime emits aDeprecationWarningpluslogger.warningwhenDATA_DESIGNER_ASYNC_ENGINE=0is set, mirroring the existingallow_resizeshape (4dfa200e). Both signals now match the precedent in_resolve_async_compatibility.