Skip to content

chore: mark docs maintenance skill internal#733

Merged
johnnygreco merged 2 commits into
mainfrom
johnny/chore-hide-datadesigner-docs-skill
Jun 9, 2026
Merged

chore: mark docs maintenance skill internal#733
johnnygreco merged 2 commits into
mainfrom
johnny/chore-hide-datadesigner-docs-skill

Conversation

@johnnygreco

Copy link
Copy Markdown
Contributor

📋 Summary

Hide the contributor-only datadesigner-docs skill from generic skills.sh discovery. The public install flow should only offer the user-facing data-designer skill.

🔗 Related Issue

N/A

🔄 Changes

  • Add metadata.internal: true to .agents/skills/datadesigner-docs/SKILL.md, matching the other internal .agents/skills entries.

🧪 Testing

  • git diff --check
  • npx --yes skills add . --list shows only data-designer
  • Unit tests added/updated: N/A — skill metadata only
  • E2E tests added/updated: N/A — skill metadata only

✅ Checklist

  • Follows commit message conventions
  • Commits are signed off (DCO)
  • Architecture docs updated: N/A — internal skill metadata only

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@johnnygreco johnnygreco requested a review from a team as a code owner June 2, 2026 17:51
@greptile-apps

greptile-apps Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Marks the datadesigner-docs maintenance skill as internal so it is excluded from public skills.sh discovery, leaving only data-designer visible to end users.

  • Adds metadata:\n internal: true to .agents/skills/datadesigner-docs/SKILL.md, matching the identical frontmatter block already present in all other .agents/skills/ entries (commit, review-code, search-docs, search-github, create-pr, update-pr).
  • No logic, runtime code, or user-facing behaviour is affected — this is a pure metadata annotation consumed by the skills CLI during listing.

Confidence Score: 5/5

Safe to merge — the change is a one-field metadata addition with no runtime impact.

The diff is a two-line frontmatter addition that matches the exact pattern already used by every other internal skill in .agents/skills/. There is no logic, no code execution path, and no user-facing behaviour changed.

No files require special attention.

Important Files Changed

Filename Overview
.agents/skills/datadesigner-docs/SKILL.md Adds metadata: internal: true to hide the skill from public discovery — consistent with all other .agents/skills/ entries (commit, review-code, search-docs, search-github, create-pr, update-pr).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["skills add . --list"] --> B{Read SKILL.md frontmatter}
    B --> C{metadata.internal == true?}
    C -- "Yes (datadesigner-docs\ncommit, review-code,\nsearch-docs, etc.)" --> D["Skip — hidden from listing"]
    C -- "No (data-designer)" --> E["Include in public list"]
Loading

Reviews (2): Last reviewed commit: "Merge branch 'main' into johnny/chore-hi..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Code Review: PR #733 — chore: mark docs maintenance skill internal

Summary

This PR adds metadata.internal: true to .agents/skills/datadesigner-docs/SKILL.md so the contributor-only docs maintenance skill is hidden from generic skills.sh discovery. Public installs should only surface the user-facing data-designer skill. The diff is 2 lines added across 1 file.

Findings

Correctness

  • The added frontmatter exactly matches the pattern already used by every other internal skill in .agents/skills/: commit, create-pr, update-pr, review-code, search-docs, and search-github all carry metadata.internal: true. The datadesigner-docs skill was the lone outlier among contributor-facing skills, so this change brings it into alignment.
  • YAML structure is valid — the metadata mapping is placed inside the existing frontmatter block before the closing ---, matching the layout in neighboring SKILL.md files.

Style / Conventions

  • Indentation (4 spaces) of the internal: true key matches the other internal skill files. Consistent.
  • No description, argument-hint, or other front-matter fields were disturbed.

Testing

  • The PR description notes manual verification via npx --yes skills add . --list showing only data-designer is offered. That is the appropriate smoke test for this kind of metadata change; no automated test coverage is warranted.

Risk / Blast radius

  • Metadata-only change in a single contributor-tooling file. No runtime code, no published package contents, no docs site content (fern/) is touched. No import-direction or layering concerns. Effectively zero risk to library users.

Suggestions

  • None. The change is minimal, correct, and consistent with the established convention.

Verdict

LGTM. Trivial, well-scoped chore that closes a small gap in the internal-skill metadata convention. Safe to merge.

@johnnygreco johnnygreco merged commit 0ed833f into main Jun 9, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants