fix: roll back setup-uv action bump#746
Conversation
|
MkDocs preview: https://44a79abd.dd-docs-preview.pages.dev Fern preview: https://nvidia-preview-pr-746.docs.buildwithfern.com/nemo/datadesigner
|
Greptile SummaryRolls back
|
| Filename | Overview |
|---|---|
| .github/workflows/build-docs.yml | Rolls back setup-uv from v8.2.0 to v8.1.0 — single mechanical pin change, no logic affected. |
| .github/workflows/build-fern-docs.yml | Rolls back setup-uv on two job steps from v8.2.0 to v8.1.0 — both hunks updated consistently. |
| .github/workflows/build-notebooks.yml | Single setup-uv pin rolled back to v8.1.0; no other changes. |
| .github/workflows/check-colab-notebooks.yml | Single setup-uv pin rolled back to v8.1.0; no other changes. |
| .github/workflows/ci.yml | Seven setup-uv pin occurrences all rolled back to v8.1.0 consistently across every job. |
| .github/workflows/docs-preview.yml | Single setup-uv pin rolled back to v8.1.0; no other changes. |
| .github/workflows/health-checks.yml | Single setup-uv pin rolled back to v8.1.0; no other changes. |
| .github/workflows/publish-devnotes.yml | Single setup-uv pin rolled back to v8.1.0; no other changes. |
| .github/workflows/publish-fern-devnotes.yml | Single setup-uv pin rolled back to v8.1.0; the failing workflow that motivated this PR — change looks correct. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["PR #739 merged\nBumped setup-uv v8.1.0 → v8.2.0"] --> B["v8.2.0 adds 5s fetch timeout\nfor manifest requests"]
B --> C["publish-fern-devnotes workflow fails\n'Install uv' step times out\nfetching uv.ndjson"]
C --> D["This PR: roll back\nsetup-uv v8.2.0 → v8.1.0\nacross all 9 workflows"]
D --> E["Pin: fac544c0… → 08807647…\n13 occurrences updated"]
E --> F["Workflows restored\nactions/checkout & FW-CI\nbumps from #739 preserved"]
Reviews (1): Last reviewed commit: "fix: roll back setup-uv action bump" | Re-trigger Greptile
SummaryPR #746 rolls back The PR keeps the FindingsCorrectness
Code Quality / Style
Risk / Operational
Test Coverage
Security
Suggestions
VerdictApprove. This is a clean, minimal, well-documented rollback that directly addresses an observed CI failure. Internal consistency verified (all 16 references updated). The only follow-up worth noting is preventing dependabot from immediately re-bumping the same pin. |
Summary
astral-sh/setup-uvfromv8.2.0tov8.1.0across workflows.actions/checkoutand FW-CI template bumps from ci: bump the all-actions group across 1 directory with 3 updates #739 intact.Root Cause
After #739 merged, the
Publish Fern devnotespush workflow failed in theInstall uvstep.setup-uv@v8.2.0added a hard 5-second fetch timeout around manifest requests; the main run timed out while fetchinghttps://raw.githubusercontent.com/astral-sh/versions/main/v1/uv.ndjsonbefore installing pinneduv0.9.5.Rolling back the action pin removes that new timeout behavior while preserving the existing
uvversions used by the workflows.Validation
make install-devgit diff --check.github/workflows/*.ymlwith PyYAMLNote: repo-wide
.venv/bin/ruff check --fix . && .venv/bin/ruff format .was attempted, but Ruff failed on an unrelated existing notebook error indocs/colab_notebooks/7-nemotron-personas.ipynb(from __future__import not at the beginning of the cell). No Python files are changed in this PR.