Skip to content

Conversation

@ka00ri
Copy link
Contributor

@ka00ri ka00ri commented Oct 17, 2025

  • rename debug cmd to info
  • include key files into displayed job infomrmation
  • fix --help to not include export flags

ka00ri and others added 23 commits October 2, 2025 02:48
@ka00ri ka00ri requested review from a team as code owners October 17, 2025 15:37
Copy link
Contributor

@marta-sd marta-sd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing the commands and found some issues. See my comments for details

@ka00ri
Copy link
Contributor Author

ka00ri commented Oct 20, 2025

@marta-sd in case of nemo-evaluator-launcher info --copy-logs , this will return jobID missing. Examples are clear on expected CLI cmd.

@marta-sd
Copy link
Contributor

@marta-sd in case of nemo-evaluator-launcher info --copy-logs , this will return jobID missing. Examples are clear on expected CLI cmd.

oooh, I see, so it's a matter of how the output of --help is rendered. The examples work perfectly fine indeed. Thanks for clarifying, this is something we should address in the future, but doesn't block this PR nor the release.

@marta-sd marta-sd merged commit 8e99a30 into main Oct 20, 2025
43 of 44 checks passed
@marta-sd marta-sd deleted the mboubdir/exporters branch October 20, 2025 19:36
@ka00ri
Copy link
Contributor Author

ka00ri commented Oct 20, 2025

Only issue rises if user executes for a list of Ids, then the first is passed as dir. To avoid this, export cmd will also require changes. Definitely to be addressed in the future.

AWarno pushed a commit that referenced this pull request Oct 23, 2025
- rename debug cmd to info
- include key files into displayed job infomrmation
- fix --help to not  include export flags

---------

Signed-off-by: Meriem B. <[email protected]>
Signed-off-by: Anna Warno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants