Skip to content

Conversation

@Abenez3r
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fixes NCCL timeout issues during async checkpoint saving for large models

Collection: Core

Changelog

  • Add configure_nccl_for_checkpointing() function to set appropriate NCCL timeouts
  • Implement automatic fallback from async to sync saving on NCCL timeouts
  • Configure NCCL environment variables for large model checkpoint operations

Testing:

  • Verified NCCL configuration function sets environment variables correctly
  • Confirmed fallback logic triggers on timeout/NCCL error patterns
  • Tested in local development environment

Usage

  • N/A

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@Abenez3r
Copy link
Author

@ericharper @titu1994 Could you review this core checkpoint fix?

- Add configure_nccl_for_checkpointing() to set appropriate timeouts
- Implement automatic fallback from async to sync on NCCL timeouts
- Configure NCCL_SOCKET_TIMEOUT and error handling for large models

Addresses NCCL timeout failures reported in NVIDIA-NeMo#14576 when using
ckpt_async_save=True with large models like Qwen3 235B"

Signed-off-by: Abenezer <[email protected]>
@Abenez3r Abenez3r force-pushed the fix-nccl-checkpoint-timeouts branch from 4b14e58 to 1f15ca9 Compare September 19, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant