-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cli): expose env-only infrastructure settings as CLI flags #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7d39790
feat(cli): add CLI flags for env-only NIM/offline/cpu settings
binaryaaron b920077
fix(cli): propagate PII runtime flags via NSS_INFERENCE_* env names
binaryaaron d70ac42
fix(tests): allowlist fake inference tokens in CLI settings tests
binaryaaron e94e8cc
refactor(cli)!: rename PII inference flags to --inference-* with NSS_…
binaryaaron b31405a
refactor(cli): rename NSS_CPU_COUNT to NSS_PII_REPLACER_CPU_COUNT
binaryaaron 92588e8
docs(env): rename duplicate Telemetry heading to fix MD024
binaryaaron c1ab315
refactor(cli): fold shared run flags into kwargs-driven settings builder
binaryaaron 883e40a
feat(cli): add InferenceModelCheck and keep CLI import hub-free for o…
binaryaaron 2ca6f4a
fix(inference): normalize blank inference env vars and fail invalid e…
binaryaaron ec8738b
chore: update cli help text
binaryaaron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--inference-api-keyis declared as a plaintype=stroption. Any value passed on the command line is visible in/proc/PID/cmdline,ps aux, shell history files, and CI logs that echo commands — all readable by other users on the same host. The canonical env-var path (NSS_INFERENCE_KEY) avoids this; the help text documents it, but does not warn that the flag itself is the insecure route. Passing--inference-api-key my-secreton a shared Slurm node or in a verbose CI step will leak the key to any co-tenant process with/procaccess.