fix(slurm): update dp configs to new shape - #689
Conversation
Signed-off-by: Nina Xu <19981858+nina-xu@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (4)**/*.yaml📄 CodeRabbit inference engine (STYLE_GUIDE.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*📄 CodeRabbit inference engine (STYLE_GUIDE.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*.{py,sh,yaml,yml,md}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
script/**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
WalkthroughChangesStructured generation configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryUpdates three differential-privacy Slurm configurations to use the current nested
Confidence Score: 5/5The PR appears safe to merge. The changed YAML structure matches the current typed configuration schema, is preserved by the Slurm-to-CLI loading path, and retains structured generation as enabled without requiring additional fields. Important Files Changed
Reviews (1): Last reviewed commit: "update dp configs to new shape" | Re-trigger Greptile |
Summary
Following up to #595, needed to update the configs for the DP runs to reflex the new shape for
structured_generation, so that slurm runs with those configs can succeed.Summary by CodeRabbit