ci: remove the NVSkills gate, which can no longer pass - #1363
Closed
SandyChapman wants to merge 1 commit into
Closed
ci: remove the NVSkills gate, which can no longer pass#1363SandyChapman wants to merge 1 commit into
SandyChapman wants to merge 1 commit into
Conversation
NVIDIA/skills#447 removed nemo-platform from the NVSkills catalog, so the validation pipeline no longer knows about this repo and can never produce the signature commit `require-nvskills` waits for. The gate is local: it fails any PR touching top-level `skills/` unless HEAD is authored by the signing bot. With no pipeline to sign, `/nvskills-ci` has nothing to dispatch to, so the check fails closed with no path to green — and because it sits in `ci-status`'s `needs`, it takes the required aggregate down with it. Any PR touching `skills/` is currently unmergeable. Removes the job, its `ci-status` entry, the `/nvskills-ci` dispatch workflow, and the corresponding CI_README section. Signed-off-by: Sandy Chapman <schapman@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe change removes NVSkills CI request and required-check workflows. It also removes their aggregate CI dependency and documentation entries. ChangesNVSkills CI removal
Merge Risk: ⚪ Minimal · up to This PR removes an obsolete CI gate and its dispatch documentation without changing product runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require-nvskillscurrently blocks every PR that touches top-levelskills/, and it cannot be made to pass.NVIDIA/skills#447 ("refactor: remove nemo-platform", merged 2026-08-13) removed
components.d/nemo-platform.ymlfrom the NVSkills catalog. The upstream validation pipeline no longer knows about this repo, so it cannot produce the signature commit the gate waits for.The gate itself is local to this repo and never consults the catalog. It fails any PR touching
skills/unless HEAD is authored bysvc-nvskills-signingwith the signature commit title. With no pipeline to dispatch to,/nvskills-cicannot produce that commit — so the check fails closed with no path to green, and since it sits inci-status'sneeds, it takes the required aggregate check down with it.Before #447 the gate was already blocked by the tier-3
--env-mode localbubblewrap failure on the nvcarps runners;pyproject.tomlstill carries a TEMPORARYtyoverride added specifically because "editing any file underskills/puts the PR behind the NVSkills gate, and that gate currently cannot pass". #447 turned a temporary block into a permanent one.Changes
require-nvskillsjob from.github/workflows/ci.yamlci-status'sneeds:list.github/workflows/request-nvskills-ci.yml(the/nvskills-cidispatch).github/CI_README.mdsectionType of Change
Quality Gates
CI_README.mdsection removed alongside the workflows it documentedVerification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
ci.yamlparses as YAMLrequire-nvskillsabsentci-statusneeds:require-nvskills/request-nvskills//nvskills-ciskills/*/BENCHMARK.mdprosetools/lint/lint-merge-conflict.shtools/lint/lint-copyright-headers.shThis PR deliberately touches no files under
skills/, so it does not gate itself.pre-commit run -awas not run to completion here: three hooks fail on this machine for missing local toolchain (helm-docs, pinned uv version, pnpm shim), none of which governs a file in this diff.Notes for reviewers
require-nvskillsis configured as a required check in branch protection or a ruleset, it must also be removed there, or PRs will block on a check that no longer runs.ci-statusremains the aggregate pin.pyproject.tomloverride. The TEMPORARYtyoverride forskills/nemo-evaluator-plugin/assets/examples/plugin_sdk_examples.pyexists only becauseskills/edits could not land; it is left in place here since its removal belongs with the fix in docs(evaluator): align the evaluator skill with main #1237.Summary by CodeRabbit
Chores
Documentation