-
Notifications
You must be signed in to change notification settings - Fork 20
fix: remove python shim for already removed codec files #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -37,6 +37,11 @@ | |||||||
| "/opt/nemo_rl_venv/lib/python3.*/site-packages/_soundfile_data/libsndfile_*.so", | ||||||||
| "/opt/ray_venvs/*/lib/python3.*/site-packages/_soundfile_data/libsndfile_*.so", | ||||||||
| "/opt/uv_cache/archive-v0/*/_soundfile_data/libsndfile_*.so", | ||||||||
| # The shim is removed with the codec; see docker/rl/codec-file-removals.txt for why | ||||||||
| # keeping it is worse than not shipping soundfile at all. | ||||||||
| "/opt/nemo_rl_venv/lib/python3.*/site-packages/soundfile.py", | ||||||||
| "/opt/ray_venvs/*/lib/python3.*/site-packages/soundfile.py", | ||||||||
| "/opt/uv_cache/archive-v0/*/soundfile.py", | ||||||||
|
coderabbitai[bot] marked this conversation as resolved.
|
||||||||
| ) | ||||||||
| BASE_VENV_MINIMUM_PYTHON_PACKAGE_VERSIONS = { | ||||||||
| "wandb": "0.28.2", | ||||||||
|
|
@@ -239,6 +244,27 @@ def test_soundfile_libsndfile_removed(): | |||||||
| assert remaining == [], f"file cleanup left scanner-visible libsndfile files: {remaining}" | ||||||||
|
|
||||||||
|
|
||||||||
| @pytest.mark.smoke_nmp_rl_training | ||||||||
| def test_transformers_audio_backend_probe_is_off(): | ||||||||
| """Removing the codec must also switch off the probe that guards its import. | ||||||||
|
|
||||||||
| ``transformers.audio_utils`` does ``if is_soundfile_available(): import soundfile``, | ||||||||
| and that probe is ``find_spec("soundfile")`` -- file presence, not loadability. Delete | ||||||||
| the codec but keep the module and the probe says yes to a backend that then fails to | ||||||||
| dlopen, so ``from transformers import AutoProcessor`` raises. That import is at module | ||||||||
| scope in ``nemo_rl.algorithms.grpo``, so the GRPO driver dies before it reads a config. | ||||||||
| """ | ||||||||
| from transformers.utils.import_utils import is_soundfile_available | ||||||||
|
|
||||||||
| assert not is_soundfile_available() | ||||||||
|
|
||||||||
|
|
||||||||
| @pytest.mark.smoke_nmp_rl_training | ||||||||
| def test_grpo_driver_module_imports(): | ||||||||
| """The exact import the GRPO driver performs first, and the one the codec strip broke.""" | ||||||||
| from nemo_rl.algorithms.grpo import MasterConfig # noqa: F401 | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
|
||||||||
|
|
||||||||
| @pytest.mark.smoke_nmp_rl_training | ||||||||
| def test_no_git_directories_shipped(): | ||||||||
| """The published image must not carry repository history. | ||||||||
|
|
||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.