fix(build): restore available Python for RL image - #1426
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe RL base image now pins Python 3.13.14, documents the uv constraint, and uses a newer pinned NeMo-RL commit. ChangesRL base image versioning
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change is limited to restoring a Linux-available Python version for the RL image, and no actionable merge-blocking risk remains at the current head. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
anubhutivyas
approved these changes
Aug 20, 2026
Signed-off-by: Swarom Muley <smuley@nvidia.com>
svvarom
force-pushed
the
svvarom/fix-rl-python-pin
branch
from
August 20, 2026 18:23
7a29343 to
bc8bf0d
Compare
ironcommit
approved these changes
Aug 20, 2026
Contributor
|
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
chore: update RL commit ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The RL base installs Python with
uv python install. PR #1351 moved it to Python 3.13.15, but uv does not have managed 3.13.15 builds for Linux. That makes the RL container build fail before PR #1415 can be tested.Change
Pin only the RL base back to Python 3.13.14. Other images remain on 3.13.15.
This is temporary and restores the previous RL security finding until uv publishes 3.13.15.
Validation
make docker-print TARGET=nmp-rl-base-builderSummary by CodeRabbit