Skip to content

fix(build): restore available Python for RL image - #1426

Merged
svvarom merged 3 commits into
mainfrom
svvarom/fix-rl-python-pin
Aug 20, 2026
Merged

fix(build): restore available Python for RL image#1426
svvarom merged 3 commits into
mainfrom
svvarom/fix-rl-python-pin

Conversation

@svvarom

@svvarom svvarom commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Why

The RL base installs Python with uv python install. PR #1351 moved it to Python 3.13.15, but uv does not have managed 3.13.15 builds for Linux. That makes the RL container build fail before PR #1415 can be tested.

Change

Pin only the RL base back to Python 3.13.14. Other images remain on 3.13.15.

This is temporary and restores the previous RL security finding until uv publishes 3.13.15.

Validation

  • uv lists Python 3.13.14 downloads for Linux AMD64 and ARM64
  • make docker-print TARGET=nmp-rl-base-builder
  • Focused Automodel/Unsloth/RL build: pending

Summary by CodeRabbit

  • Chores
    • Updated the default Python version used by the runtime image.
    • Clarified documentation around supported Python builds and the uv networking dependency constraint.
    • Updated the NeMo-RL base image to a newer pinned release for improved compatibility and maintenance.

@github-actions github-actions Bot added the fix label Aug 20, 2026
@svvarom svvarom self-assigned this Aug 20, 2026
@svvarom
svvarom marked this pull request as ready for review August 20, 2026 18:13
@svvarom
svvarom requested review from a team as code owners August 20, 2026 18:13
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1f6d0820-a68d-48e1-9295-611895de84f8

📥 Commits

Reviewing files that changed from the base of the PR and between 7a29343 and 1fdc877.

📒 Files selected for processing (1)
  • docker-bake.hcl

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The RL base image now pins Python 3.13.14, documents the uv constraint, and uses a newer pinned NeMo-RL commit.

Changes

RL base image versioning

Layer / File(s) Summary
Base image version pins
docker/rl/Dockerfile.nmp-rl-base, docker-bake.hcl
The default PYTHON_VERSION changes from 3.13.15 to 3.13.14. The comments document the uv and quinn-proto constraints. UV_VERSION remains 0.11.33. NEMO_RL_REF changes to commit cd42a71d6d4b2eeb6f3d2feef275c5795d2f008c.

Suggested reviewers: a2bondar

Merge Risk: ⚪ Minimal · up to 1fdc8

The change is limited to restoring a Linux-available Python version for the RL image, and no actionable merge-blocking risk remains at the current head.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: restoring the available Python version for the RL image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch svvarom/fix-rl-python-pin

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Swarom Muley <smuley@nvidia.com>
@svvarom
svvarom force-pushed the svvarom/fix-rl-python-pin branch from 7a29343 to bc8bf0d Compare August 20, 2026 18:23
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 34424/43432 79.3% 64.1%
Integration Tests 20322/41231 49.3% 22.0%

anubhutivyas and others added 2 commits August 20, 2026 14:04
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
@svvarom
svvarom added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 0039512 Aug 20, 2026
60 checks passed
@svvarom
svvarom deleted the svvarom/fix-rl-python-pin branch August 20, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants