Skip to content

fix: keep SDK importable without platform_ext, related automodel image fixes #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mckornfield merged 2 commits into from
Aug 25, 2026
Merged

fix: keep SDK importable without platform_ext, related automodel image fixes #1510

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f32d04
fix: keep SDK importable without platform ext
mckornfield Aug 25, 2026
c77c424
fix: include filesets in automodel image
mckornfield Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/nemo_platform_ext/src/nemo_platform_ext/client/enhanced.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
)
from nemo_platform._base_client import AsyncAPIClient, SyncAPIClient
from nemo_platform_plugin.client.constants import WORKLOAD_IDENTITY_TOKEN_FILE_ENVVAR

from nemo_platform_ext.client.tls import client_verify_from_env
from nemo_platform_plugin.client.tls import client_verify_from_env


def _should_bootstrap_config(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/nemo-platform/src/nemo_platform/_client.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion tools/nemo-platform-sdk-tools/src/nemo_platform_sdk_tools/sdk/vendor/vendor_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,13 @@ class ResourceReplacement(BaseModel):
_CLIENT_HELPER_FUNCTION_NAMES = ("_should_bootstrap_config", "_copy_requires_bootstrap")
_CLIENT_INIT_REQUIRED_IMPORTS: dict[str, tuple[str, ...]] = {
"nemo_platform._base_client": ("DefaultAsyncHttpxClient", "DefaultHttpxClient"),
"nemo_platform_ext.client.tls": ("client_verify_from_env",),
"nemo_platform_plugin.client.constants": ("WORKLOAD_IDENTITY_TOKEN_FILE_ENVVAR",),
"nemo_platform_plugin.client.tls": ("client_verify_from_env",),
"pathlib": ("Path",),
}
_STALE_CLIENT_INIT_IMPORTS: dict[str, tuple[str, ...]] = {
"nemo_platform.client.tls": ("client_verify_from_env",),
"nemo_platform_ext.client.tls": ("client_verify_from_env",),
}


Expand Down
4 changes: 3 additions & 1 deletion tools/nemo-platform-sdk-tools/tests/sdk/vendor/test_vendor_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,7 @@ def test_replace_client_methods_updates_init_and_getattr(tmp_path: Path) -> None
client_path.write_text(
"""
from typing import Any
from nemo_platform_ext.client.tls import client_verify_from_env
def _should_bootstrap_config(config_path: object | None = None) -> bool:
Expand Down Expand Up @@ -1096,8 +1097,9 @@ def __getattr__(self, name: str) -> Any:

assert "from pathlib import Path" in updated
assert "from nemo_platform._base_client import DefaultAsyncHttpxClient, DefaultHttpxClient" in updated
assert "from nemo_platform_ext.client.tls import client_verify_from_env" in updated
assert "from nemo_platform_plugin.client.constants import WORKLOAD_IDENTITY_TOKEN_FILE_ENVVAR" in updated
assert "from nemo_platform_plugin.client.tls import client_verify_from_env" in updated
assert "from nemo_platform_ext.client.tls import client_verify_from_env" not in updated
Comment thread
mckornfield marked this conversation as resolved.
assert "def _should_bootstrap_config(config_path: Path | None = None) -> bool:" in updated
assert "return config_path is not None" in updated
assert "return False" not in updated
Expand Down
Loading