Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing index buffer offset for skinned mesh instance. #25

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

HanetakaChou
Copy link
Contributor

 // ...

 for (const auto& skinnedInstance : m_SceneGraph->GetSkinnedMeshInstances())
    {
        const auto& skinnedMesh = skinnedInstance->GetMesh();

        if (!skinnedMesh->buffers)
        {
            skinnedMesh->buffers = std::make_shared<BufferGroup>();

            uint32_t totalVertices = skinnedMesh->totalVertices;

            skinnedMesh->buffers->indexBuffer = skinnedInstance->GetPrototypeMesh()->buffers->indexBuffer;
            skinnedMesh->buffers->indexBufferDescriptor = skinnedInstance->GetPrototypeMesh()->buffers->indexBufferDescriptor;

 // ...

According to the above code within Scene::CreateMeshBuffers, the same index buffer may be shared by different skinned meshes.

Thus, the index offset should NOT be omitted when creating the skinned mesh.

@HanetakaChou
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@HanetakaChou
Copy link
Contributor Author

@apanteleev

@VinnyVicious
Copy link

Also need this. Thanks @HanetakaChou

@apanteleev apanteleev merged commit 140f3a2 into NVIDIA-RTX:main Jan 15, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants