-
Notifications
You must be signed in to change notification settings - Fork 70
Clip slice range expressions #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f9def57
Add clipping to slice output extent expressions
jacobhinkle 15587bd
Merge branch 'main' into slice_clip
jacobhinkle 2c4af30
Add where to ExpressionEvaluator, handle negative in slice
jacobhinkle 2b4ef9a
Merge remote-tracking branch 'origin/main' into slice_clip
jacobhinkle 5dcf2c8
Support Set,Where, bool ops in NaiveValueMachine
jacobhinkle 7432adb
Silence clang-tidy in test_resize.cpp
jacobhinkle d96ee2e
Merge remote-tracking branch 'origin/main' into slice_clip
jacobhinkle 9856d93
Add simplifying comparison operators
jacobhinkle 8544650
Clean up normalized slice start/stop expressions
jacobhinkle eee9ff2
Fix wrong ostream in preseg ir dump
jacobhinkle efcb203
Remove debug print
jacobhinkle bf0a4b6
Handle NE in runBinaryOp
jacobhinkle 121a3b9
Fix simplified comparison ops
jacobhinkle 93f3737
Use maybeCastExpr in resize
jacobhinkle ec315a1
Update doc comment on slice op
jacobhinkle 98f3519
Add input range test
jacobhinkle b557e38
Reformat test
jacobhinkle 5b06adc
Merge branch 'main' into slice_clip
jacobhinkle 72493d2
Simplify clipping exprs, clean up op
jacobhinkle 553e63d
Merge remote-tracking branch 'origin/main' into slice_clip
jacobhinkle a9d9e58
Simplify maybe cast exprs
jacobhinkle 90f9616
Remove unneeded change to nodes.cpp
jacobhinkle ca3a674
Restore check for trivial slice
jacobhinkle 2fd5c23
Use SimplifyingIrBuilder
jacobhinkle 2bc4748
Cast extent first
jacobhinkle 2f714a8
Merge branch 'main' into slice_clip
jacobhinkle 2331989
Adding a reshape example (#944)
naoyam 74eb074
Remove manual refs and add FEC test
jacobhinkle d7a4b56
Change check for invalid extents to be >= 0
jacobhinkle 87dae14
Use same set of slice cases for all three tests
jacobhinkle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.