Skip to content

Fix invalid label key format in GPU group handling. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix invalid label key format in GPU group handling. #110

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
391e8a9
Fix invalid label key format in GPU group handling.
Apr 30, 2025
515afbc
apply feedback for logger.
May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/binder/binding/resourcereservation/resource_reservation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation/group_mutex"
"github.com/NVIDIA/KAI-scheduler/pkg/common/constants"
"github.com/NVIDIA/KAI-scheduler/pkg/common/resources"
infralogger "github.com/NVIDIA/KAI-scheduler/pkg/scheduler/log"
)

type Interface interface {
Expand Down Expand Up @@ -123,6 +124,11 @@ func (rsc *service) SyncForGpuGroup(ctx context.Context, gpuGroup string) error
}

func (rsc *service) syncForGpuGroupWithLock(ctx context.Context, gpuGroup string) error {
if gpuGroup == "" {
// Skip empty GPU groups
infralogger.InfraLogger.Warningf("Skipping sync for empty GPU group")
return nil
}
podsList := &v1.PodList{}
err := rsc.kubeClient.List(ctx, podsList,
client.MatchingLabels{constants.GPUGroup: gpuGroup},
Expand Down