feat(admission): Explicitly apply 'nvidia' runtimeClass to GPU pods #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
reviewed
Oct 27, 2025
omeryahud
force-pushed
the
omeryahud/explicitly-set-nvidia-runtimeclass-to-gpu-pods
branch
4 times, most recently
from
7f784cb to
e17accd
Compare
… deploys it as the default runtimeClass Signed-off-by: Omer Yahud <[email protected]>
omeryahud
force-pushed
the
omeryahud/explicitly-set-nvidia-runtimeclass-to-gpu-pods
branch
2 times, most recently
from
a52fb40 to
e66fffb
Compare
Signed-off-by: Omer Yahud <[email protected]>
omeryahud
force-pushed
the
omeryahud/explicitly-set-nvidia-runtimeclass-to-gpu-pods
branch
from
e66fffb to
69bc8fc
Compare
Merging this branch changes the coverage (3 decrease, 3 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
enoodle
reviewed
Nov 3, 2025
pkg/admission/webhook/v1alpha2/runtimeenforcement/runtime_enforcement.go
Outdated
Show resolved
Hide resolved
omeryahud
force-pushed
the
omeryahud/explicitly-set-nvidia-runtimeclass-to-gpu-pods
branch
from
b91d157 to
65b85ed
Compare
enoodle
reviewed
Nov 3, 2025
omeryahud
changed the title
enoodle
previously approved these changes
Nov 3, 2025
itsomri
reviewed
Nov 3, 2025
itsomri
previously approved these changes
Nov 3, 2025
Merging this branch changes the coverage (3 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
omeryahud
force-pushed
the
omeryahud/explicitly-set-nvidia-runtimeclass-to-gpu-pods
branch
from
65b85ed to
75fc3e6
Compare
Merging this branch changes the coverage (3 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
…tor instead Signed-off-by: Omer Yahud <[email protected]>
omeryahud
force-pushed
the
omeryahud/explicitly-set-nvidia-runtimeclass-to-gpu-pods
branch
from
75fc3e6 to
94364d9
Compare
Merging this branch changes the coverage (3 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
enoodle
previously approved these changes
Nov 4, 2025
Signed-off-by: Omer Yahud <[email protected]>
itsomri
approved these changes
Nov 4, 2025
Merging this branch changes the coverage (3 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Merging this branch changes the coverage (3 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming release, gpu-operator no longer sets the
nvidiaruntime class as the default runtimeClass in the cluster, hence the need to set it explicitly for pod that request GPUs