Skip to content

Add cpu-only extra for torch cpu dependency #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voegtlel wants to merge 4 commits into
base: develop
Choose a base branch
from
+2,518 −2,393
Open

Add cpu-only extra for torch cpu dependency #210

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7931d05
Add cpu-only extra for torch cpu dependency
voegtlel Mar 12, 2026
ab8ee64
Add tool install instructions
voegtlel Mar 12, 2026
6f4f26f
Add docs to pyproject
voegtlel Mar 12, 2026
d262e15
Revert pyproject cpu only torch. Update uv lock dependencies. Update …
voegtlel Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ transforms = [
"torchvision", # Needed for megatron.energon.transforms
]

# Special cpu-only pytorch dependency (see below in tool.uv.sources)
cpu-only = [
"torch",
]


# Storage services for MSC
s3 = [
"multi-storage-client[boto3]",
Expand Down Expand Up @@ -111,3 +117,12 @@ exclude = [
"docs",
]

[tool.uv.sources]
torch = [
Copy link
Collaborator

@philipp-fischer philipp-fischer Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that it doesn't also override torch to CPU when not using the "cpu-only" extra?

Copy link
Collaborator Author

@voegtlel voegtlel Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, found out that this is actually broken. It would now always use the cpu version :-/ Reverted that change now, added instructions for uv tool.

{ index = "pytorch-cpu", extra = "cpu-only" },
]

[[tool.uv.index]]
name = "pytorch-cpu"
url = "https://download.pytorch.org/whl/cpu"
explicit = true
Loading
Loading