Skip to content

Support dict output_tensor in forward_step_calc_loss #4476

Open
Prachi-kushwaha wants to merge 5 commits intoNVIDIA:mainfrom
Prachi-kushwaha:fix-get-tensor-device-multimodal
Open

Support dict output_tensor in forward_step_calc_loss #4476
Prachi-kushwaha wants to merge 5 commits intoNVIDIA:mainfrom
Prachi-kushwaha:fix-get-tensor-device-multimodal

Conversation

@Prachi-kushwaha
Copy link
Copy Markdown

@Prachi-kushwaha Prachi-kushwaha commented Apr 26, 2026

What does this PR do ?

Fix get_tensor_device to support structured outputs (dict/list) in multimodal pipeline parallelism.

#4474

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft April 26, 2026 17:04
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@Prachi-kushwaha Prachi-kushwaha marked this pull request as ready for review April 26, 2026 21:54
@Prachi-kushwaha Prachi-kushwaha requested review from a team as code owners April 26, 2026 21:54
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 26, 2026 21:55
@Prachi-kushwaha Prachi-kushwaha changed the title Start draft PR for get_tensor_device fix Support dict output_tensor in forward_step_calc_loss (fix device access error) Apr 28, 2026
@Prachi-kushwaha Prachi-kushwaha changed the title Support dict output_tensor in forward_step_calc_loss (fix device access error) Support dict output_tensor in forward_step_calc_loss Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants