Skip to content

test: skip mfsdp_fully_shard cases when world_size < mesh size #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wujingyue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: skip mfsdp_fully_shard cases when world_size < mesh size #4487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/unit_tests/distributed/megatron_fsdp/test_mfsdp_fully_shard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.

import logging
import math
import shutil
from contextlib import nullcontext
from copy import deepcopy
Expand Down Expand Up @@ -211,6 +212,14 @@ def build_distributed_environment(mesh_dim_config: tuple):
"""
from torch.distributed.device_mesh import init_device_mesh

required_world_size = math.prod(mesh_dim_config)
world_size = torch.distributed.get_world_size()
if world_size < required_world_size:
pytest.skip(
f"This test requires {required_world_size} GPUs for mesh "
f"{mesh_dim_config}, but only {world_size} are available"
)

# Construct device mesh.
device_mesh = init_device_mesh(
"cuda", mesh_shape=mesh_dim_config, mesh_dim_names=(DP_OUTER, DP_SHARD, CP, TP)
Expand Down
Loading