Conversation
deepujain
force-pushed
the
fix/3738-remove-gather-rounds
branch
from
September 3, 2026 02:17
2639092 to
4259e7e
Compare
deepujain
force-pushed
the
fix/3738-remove-gather-rounds
branch
from
September 24, 2026 21:49
4259e7e to
135eb49
Compare
Signed-off-by: dejain <deepujain@gmail.com> Signed-off-by: Deepak Jain <deepujain@gmail.com>
deepujain
force-pushed
the
fix/3738-remove-gather-rounds
branch
from
September 29, 2026 23:26
135eb49 to
42e91e4
Compare
deepujain
marked this pull request as ready for review
September 29, 2026 23:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
gather_roundscheckpoint exchange path has caused numerical instability in production workloads. This change removes that implementation and configuration choice while retaining thebroadcastdefault and thegather_objectdebugging option.The load-strategy documentation and FP8 test parameterization are updated so users can no longer select the unstable path. Unknown exchange algorithms continue to fail explicitly with
NotImplementedError.Issue tracking
Fixes #3738
Contribution process
Pre-checks
Validation
exchange_by_distribution(..., exchange_algo="gather_rounds")now raisesNotImplementedError; the repaired diff preserves that removal unchanged.gather_roundsreferences.python3 -m py_compileandgit diff --checkpassed for all changed files.The repaired commit is rebased on current
mainand signed. The distributed FP8 checkpoint test requires the repository's multi-GPU environment and remains a hosted CI gate.