Skip to content

fix(test): recreate tmpDir per test in onboard-session.test.ts (#1284) #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 2 commits into from
Apr 9, 2026
+7 −1
Merged

fix(test): recreate tmpDir per test in onboard-session.test.ts (#1284) #1562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beba464
fix(test): recreate tmpDir per test in onboard-session.test.ts
ColinM-sys Apr 7, 2026
e36eb67
Merge branch 'main' into fix/1284-onboard-session-tmpdir-isolation
cv Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib/onboard-session.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,21 @@ import os from "node:os";
import path from "node:path";
import { createRequire } from "node:module";

const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-onboard-session-"));
const require = createRequire(import.meta.url);
// Clear both the shim and the dist module so HOME changes take effect.
const shimPath = require.resolve("../../bin/lib/onboard-session");
const distPath = require.resolve("../../dist/lib/onboard-session");
const originalHome = process.env.HOME;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
let session: any;
let tmpDir: string;

beforeEach(() => {
// Recreate tmpDir per test so lock artifacts (and any other on-disk state)
// from a previous test cannot leak into this one. Without this, malformed
// lock files left behind by releaseOnboardLock() make lock tests
// order-dependent. See issue #1284.
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-onboard-session-"));
process.env.HOME = tmpDir;
delete require.cache[shimPath];
delete require.cache[distPath];
Expand All @@ -28,6 +33,7 @@ beforeEach(() => {
afterEach(() => {
delete require.cache[shimPath];
delete require.cache[distPath];
fs.rmSync(tmpDir, { recursive: true, force: true });
if (originalHome === undefined) {
delete process.env.HOME;
} else {
Expand Down
Loading