fix(scripts): remove static issue line from release PR template#1596
fix(scripts): remove static issue line from release PR template#1596brandonpelfrey wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe version bump script's PR body generation was refactored to dynamically reflect whether formatting and tests were executed during the release process. The function signature was updated to accept runtime state, and the PR template was simplified by removing the related issue section. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Fix the release PR body generated by
scripts/bump-version.tsso it no longer includes a static issue-closing line for version bumps.This also corrects an oversight introduced in #1581 by making the test and formatting checkboxes reflect what the script actually ran.
Related Issue
Changes
Fixes #1577.line from the generated release PR bodybuildPrBody()accept runtime status sonpm testand formatting checklist items match the actual runType of Change
Testing
npx prek run --all-filespasses (or equivalentlymake check).npm testpasses.make docsbuilds without warnings. (for doc-only changes)Checklist
General
Code Changes
npx prek run --all-filesauto-fixes formatting (ormake formatfor targeted runs).Doc Changes
update-docsagent skill to draft changes while complying with the style guide. For example, prompt your agent with "/update-docscatch up the docs for the new changes I made in this PR."Signed-off-by: Brandon Pelfrey [email protected]
Summary by CodeRabbit