-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(image): route exec approvals to .openclaw-data #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skainguyen1412
wants to merge
6
commits into
NVIDIA:main
Choose a base branch
from
skainguyen1412:fix/1785-exec-approvals-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−0
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9d836eb
fix(image): patch exec approvals path for symlink-safe state
skainguyen1412 b605f63
fix(image): address exec approvals review findings
skainguyen1412 7761287
fix(image): harden runtime exec approvals path guard
skainguyen1412 305b9ba
fix(image): satisfy Dockerfile lint checks
skainguyen1412 0ae01c7
Merge branch 'main' into fix/1785-exec-approvals-path
skainguyen1412 de6d4b2
fix(image): ensure exec approvals data dir is writable
skainguyen1412 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // @ts-nocheck | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import fs from "node:fs"; | ||
| import path from "node:path"; | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| describe("exec approvals path regression guard", () => { | ||
| it("Dockerfile.base patches and validates OpenClaw exec approvals path across dist bundles", () => { | ||
| const dockerfileBase = path.join(import.meta.dirname, "..", "Dockerfile.base"); | ||
| const src = fs.readFileSync(dockerfileBase, "utf-8"); | ||
|
|
||
| expect(src).toContain('LEGACY_EXEC_APPROVALS_PATH="$(printf \'%b\''); | ||
| expect(src).toContain('DATA_EXEC_APPROVALS_PATH="$(printf \'%b\''); | ||
| expect(src).toContain('files_with_old_path_file="$(mktemp)"'); | ||
| expect(src).toContain("--include='*.js'"); | ||
| expect(src).toContain("OpenClaw dist directory not found:"); | ||
| expect(src).toContain("Unable to verify OpenClaw exec approvals path in dist"); | ||
| }); | ||
|
|
||
| it("Dockerfile applies a runtime compatibility patch for stale base images", () => { | ||
| const dockerfile = path.join(import.meta.dirname, "..", "Dockerfile"); | ||
| const src = fs.readFileSync(dockerfile, "utf-8"); | ||
|
|
||
| expect(src).toContain('[ ! -d "$OPENCLAW_DIST_DIR" ]'); | ||
| expect(src).toContain('LEGACY_EXEC_APPROVALS_PATH="$(printf \'%b\''); | ||
| expect(src).toContain('DATA_EXEC_APPROVALS_PATH="$(printf \'%b\''); | ||
| expect(src).toContain('files_with_old_path_file="$(mktemp)"'); | ||
| expect(src).toContain("--include='*.js'"); | ||
| expect(src).toContain("Unable to verify OpenClaw exec approvals path in dist"); | ||
| expect(src).toContain("OpenClaw dist directory not found:"); | ||
| expect(src).toContain("OpenClaw exec approvals path patch failed"); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.