fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990
Open
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Fixes NVIDIA#1744. GLM-5 is deprecated per NVIDIA API Catalog notice (Apr 9 – May 9, 2026 migration window; full shutdown May 9). The successor is GLM-5.1, which the catalog already serves at the same provider prefix. Swap every curated reference to the new model id and label: - src/lib/inference-config.ts:16 — CLOUD_MODEL_OPTIONS picker entry - src/lib/inference-config.test.ts — id-list assertion - src/lib/inventory-commands.test.ts — sandbox-list fixtures - test/onboard-selection.test.ts — mocked /v1/models response + selection answers + expected model - docs/inference/inference-options.md — NVIDIA Endpoints example list - .agents/skills/nemoclaw-user-configure-inference/SKILL.md - .agents/skills/nemoclaw-user-configure-inference/references/ inference-options.md No code-path changes. Users with existing sandboxes still pinned to `z-ai/glm5` will need to rebuild during the migration window — the gateway's redirect handles in-flight traffic until T-0. All 22 tests in the two affected files pass. Signed-off-by: ColinM-sys <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe pull request updates model references across documentation and code files, replacing the deprecated GLM-5 model identifier ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swap every curated `z-ai/glm5` reference to `z-ai/glm-5.1` ahead of the May 9, 2026 full-deprecation date. The successor is already served at the same provider prefix, so this is a straight id/label rename.
Fixes #1744.
Files changed
Why now
Per the deprecation notice (issue #1744):
Landing this before May 9 ensures the curated picker and docs no longer suggest a model that will return hard errors post-T0.
Migration note for existing users
Users with sandboxes already pinned to `z-ai/glm5` will keep working via the gateway redirect through the migration window. A rebuild after this PR lands will pick up the new default automatically.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores