Skip to content

fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990

Open
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/1744-glm5-deprecation
Open

fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/1744-glm5-deprecation

Conversation

@ColinM-sys
Copy link
Copy Markdown
Contributor

@ColinM-sys ColinM-sys commented Apr 16, 2026

Summary

Swap every curated `z-ai/glm5` reference to `z-ai/glm-5.1` ahead of the May 9, 2026 full-deprecation date. The successor is already served at the same provider prefix, so this is a straight id/label rename.

Fixes #1744.

Files changed

  • `src/lib/inference-config.ts` — `CLOUD_MODEL_OPTIONS` picker entry
  • `src/lib/inference-config.test.ts` — id-list assertion
  • `src/lib/inventory-commands.test.ts` — sandbox-list fixtures
  • `test/onboard-selection.test.ts` — mocked `/v1/models` response + selection answers + expected model
  • `docs/inference/inference-options.md` — NVIDIA Endpoints example list
  • `.agents/skills/nemoclaw-user-configure-inference/SKILL.md`
  • `.agents/skills/nemoclaw-user-configure-inference/references/inference-options.md`

Why now

Per the deprecation notice (issue #1744):

  • Apr 9, 2026 — Deprecation notice + banner live (gateway redirect active during migration window)
  • May 9, 2026 — GLM-5 fully shut down
  • Successor: GLM-5.1

Landing this before May 9 ensures the curated picker and docs no longer suggest a model that will return hard errors post-T0.

Migration note for existing users

Users with sandboxes already pinned to `z-ai/glm5` will keep working via the gateway redirect through the migration window. A rebuild after this PR lands will pick up the new default automatically.

Test plan

  • `npm run build:cli` — clean
  • `npx vitest run src/lib/inference-config.test.ts src/lib/inventory-commands.test.ts` — 22/22 pass
  • No remaining `glm5` or `GLM-5` (pre-.1) references anywhere in the tree
  • No code-path changes — purely a string rename

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated NVIDIA Endpoints model option from GLM-5 to GLM-5.1 across inference configuration documentation.
  • Chores

    • Updated model identifier references in configuration and tests.

Fixes NVIDIA#1744.

GLM-5 is deprecated per NVIDIA API Catalog notice (Apr 9 – May 9,
2026 migration window; full shutdown May 9). The successor is
GLM-5.1, which the catalog already serves at the same provider
prefix.

Swap every curated reference to the new model id and label:
- src/lib/inference-config.ts:16 — CLOUD_MODEL_OPTIONS picker entry
- src/lib/inference-config.test.ts — id-list assertion
- src/lib/inventory-commands.test.ts — sandbox-list fixtures
- test/onboard-selection.test.ts — mocked /v1/models response +
  selection answers + expected model
- docs/inference/inference-options.md — NVIDIA Endpoints example list
- .agents/skills/nemoclaw-user-configure-inference/SKILL.md
- .agents/skills/nemoclaw-user-configure-inference/references/
  inference-options.md

No code-path changes. Users with existing sandboxes still pinned to
`z-ai/glm5` will need to rebuild during the migration window — the
gateway's redirect handles in-flight traffic until T-0.

All 22 tests in the two affected files pass.

Signed-off-by: ColinM-sys <[email protected]>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 53c970ee-55d6-4cbf-8ea1-9babf882c637

📥 Commits

Reviewing files that changed from the base of the PR and between 8c770ad and 6aeb15b.

📒 Files selected for processing (7)
  • .agents/skills/nemoclaw-user-configure-inference/SKILL.md
  • .agents/skills/nemoclaw-user-configure-inference/references/inference-options.md
  • docs/inference/inference-options.md
  • src/lib/inference-config.test.ts
  • src/lib/inference-config.ts
  • src/lib/inventory-commands.test.ts
  • test/onboard-selection.test.ts

📝 Walkthrough

Walkthrough

The pull request updates model references across documentation and code files, replacing the deprecated GLM-5 model identifier (z-ai/glm5) with its successor GLM-5.1 (z-ai/glm-5.1) in response to the announced deprecation timeline for GLM-5.

Changes

Cohort / File(s) Summary
Documentation Updates
.agents/skills/nemoclaw-user-configure-inference/SKILL.md, .agents/skills/nemoclaw-user-configure-inference/references/inference-options.md, docs/inference/inference-options.md
Updated NVIDIA Endpoints curated models list, replacing GLM-5 with GLM-5.1 in model documentation and reference materials.
Source Configuration
src/lib/inference-config.ts
Updated the exported CLOUD_MODEL_OPTIONS constant, changing model entry from { id: "z-ai/glm5", label: "GLM-5" } to { id: "z-ai/glm-5.1", label: "GLM-5.1" }.
Test Updates
src/lib/inference-config.test.ts, src/lib/inventory-commands.test.ts, test/onboard-selection.test.ts
Updated test expectations and mocked model identifiers to reflect the new GLM-5.1 model across multiple test suites, including sandbox model assertions and NVIDIA Endpoints validation tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From GLM-5 we hop away,
To GLM-5.1's bright day!
Through docs and tests, the update flows,
A migration journey as the calendar shows. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: migrating GLM-5 model references to GLM-5.1, which directly matches the changeset's focus across all modified files.
Linked Issues check ✅ Passed The pull request successfully addresses all coding requirements from issue #1744: replaces GLM-5 references with GLM-5.1 in curated model options, test fixtures, and documentation to support the migration during the Apr 9–May 9 window.
Out of Scope Changes check ✅ Passed All changes are in-scope and directly support the GLM-5 to GLM-5.1 migration objective; no unrelated modifications to other functionality, code-paths, or features were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model Deprecation – [API Catalog] [glm5] [10 Days Notice]

1 participant