Skip to content

[None][test] fix MPI pool fixture parametrization #15354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cascade812 wants to merge 5 commits into
base: main
Choose a base branch
from
+23 −23
Open

[None][test] fix MPI pool fixture parametrization #15354

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9d8dea
[None][test] fix MPI pool fixture parametrization
cascade812 Jun 14, 2026
24db587
[None][test] fix chunked prefill parametrization
cascade812 Jun 15, 2026
ee6a472
[None][infra] constrain click for spin compatibility
cascade812 Jun 15, 2026
387289f
[None][test] move multimodal fixture params to tests
cascade812 Jun 15, 2026
ff5feb5
[None][test] apply multimodal test formatting
cascade812 Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/unittest/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -337,12 +337,12 @@ def torch_empty_cache() -> None:
torch.cuda.empty_cache()


@pytest.fixture(scope="module", params=[2, 4, 8])
@pytest.fixture(scope="module")
def mpi_pool_executor(request):
"""
Start an MPIPoolExecutor with `request.param` workers.
"""
num_workers = request.param
num_workers = getattr(request, "param", 2)
with MPIPoolExecutor(num_workers) as executor:
# make the number of workers visible to tests
setattr(executor, "num_workers", num_workers)
Expand Down
Loading