[TRTLLM-12721][fix] Bound V2 context transfer polling#15356
Draft
chienchunhung wants to merge 2 commits into
Draft
[TRTLLM-12721][fix] Bound V2 context transfer polling#15356chienchunhung wants to merge 2 commits into
chienchunhung wants to merge 2 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #54156 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #54156 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up draft PR for V2 Python transceiver bounded polling.
This keeps the V2 change separate from:
Behavior
blockingargument to V2TxSession.wait_complete().KvCacheTransceiverV2.check_context_transfer_status(at_least_request_num=...)use nonblocking TxSession polling for bounded scheduler polls.Nonefrom the nonblocking TxSession poll as "not ready yet"; the request remains queued and is polled again later.blockAll/at_least_request_num=Noneas a blocking wait-all path.Relationship to #15181
This PR is related to #15181's bounded-polling contract, but it is intentionally V2/Python-transceiver only and is opened against
mainto keep the diff focused. It can be reviewed after or alongside #15181 without carrying the C++ transceiver changes in this PR.Local validation
PYTHONPYCACHEPREFIX=/private/tmp/trtllm-pycache python -m py_compile tensorrt_llm/_torch/disaggregation/base/transfer.py tensorrt_llm/_torch/disaggregation/transceiver.py tensorrt_llm/_torch/disaggregation/native/transfer.pygit diff --check upstream/main..HEADPATH=/opt/miniconda3/bin:$PATH PRE_COMMIT_HOME=/private/tmp/trtllm-pre-commit pre-commit run --files tensorrt_llm/_torch/disaggregation/base/transfer.py tensorrt_llm/_torch/disaggregation/transceiver.py tensorrt_llm/_torch/disaggregation/native/transfer.pyFocused pytest attempt was blocked locally by missing dependency
transformers.