[Plugin] Fix bug of memcpy in scatter plugin #3818
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge release/10.0 to main
Signed-off-by: seel.xu <[email protected]>
kevinch-nv
requested review from
LeoZDong and
kevinch-nv
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scatter plugin,
cudaMemcpywith implicit synchronization is used to complete data copying, ensuring thatdevice_transform_coeffis properly assigned before the kernel execution. However, this method fails when usingcudaStreamNonBlockingstream for inference in TensorRT, resulting in incorrect outcomes. This issue can be resolved by switching tocudaMemcpyAsyncand using the same stream as the kernel, yielding correct results.