Skip to content

Make CanonicalizeGemmInput() support non-TN layout FP8 GEMM on Blackwell with column-wise/transposed data #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Draft

Make CanonicalizeGemmInput() support non-TN layout FP8 GEMM on Blackwell with column-wise/transposed data #2233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions transformer_engine/common/gemm/cublaslt_gemm.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,16 @@ GemmParam CanonicalizeGemmInput(const transformer_engine::Tensor &A, const cubla
} else {
NVTE_CHECK(!is_fp8_dtype(ret.Atype), "Input A is missing column-wise usage");
}
} else if (nvte_is_non_tn_fp8_gemm_supported() && !A.has_data()) {
// Blackwell supports any GEMM layout for FP8, so we can use column-wise/transposed
// data with the mirrored transpose-flag if we don't have row-wise data.
NVTE_CHECK(A.has_columnwise_data() && is_fp8_dtype(A.columnwise_data.dtype),
"Input A is missing column-wise usage");
ret.A = A.columnwise_data.dptr;
ret.transA = is_A_transposed ? CUBLAS_OP_N : CUBLAS_OP_T;
ret.Atype = A.columnwise_data.dtype;
ret.A_scale_inv = A.columnwise_scale_inv.dptr;
ret.lda = is_A_transposed ? m : k;
}
} else if (is_mxfp_scaling(A.scaling_mode)) {
// MXFP8
Expand Down Expand Up @@ -160,6 +170,16 @@ GemmParam CanonicalizeGemmInput(const transformer_engine::Tensor &A, const cubla
} else {
NVTE_CHECK(!is_fp8_dtype(ret.Btype), "Input B is missing column-wise usage");
}
} else if (nvte_is_non_tn_fp8_gemm_supported() && !B.has_data()) {
// Blackwell supports any GEMM layout for FP8, so we can use column-wise/transposed
// data with the mirrored transpose-flag if we don't have row-wise data.
NVTE_CHECK(B.has_columnwise_data() && is_fp8_dtype(B.columnwise_data.dtype),
"Input B is missing column-wise usage");
ret.B = B.columnwise_data.dptr;
ret.transB = is_B_transposed ? CUBLAS_OP_N : CUBLAS_OP_T;
ret.Btype = B.columnwise_data.dtype;
ret.B_scale_inv = B.columnwise_scale_inv.dptr;
ret.ldb = is_B_transposed ? k : n;
}
} else if (is_mxfp_scaling(B.scaling_mode)) {
// MXFP8
Expand Down