[PyTorch Debug] Fix issue with start_end_list logging feature #2252
+27
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Debug tool in TE allows user to set non-overlapping list of (start, end) pairs in which logging will occur at specified frequency. This MR address two bugs with start_end_list functionality.
start_end_list
was directly being usedList
in stats_buffer, leading to unhashable type error at the first logging interval. List is converted to nested tuples in LogTensorStats and LogFP8TensorStats which resolves the issue.next_iter=None
when using start_end_list and we face type error when checkingiteration >= next_iter
in stats_buffer.py below.Checklist: