Don't pickle an empty dict in LayerNorm and pt base modules #2253
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter St. John <[email protected]>
pstjohn
force-pushed
the
pstjohn/dont-serialize-empty-dict
branch
from
f0ddcbd to
040c3ba
Compare
ksivaman
approved these changes
Oct 9, 2025
|
/te-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
LayerNormlayer doesn't inherit fromTransformerEngineBaseModule, and so it doesn't have the updated process of using an empty tensor to denote no fp8 metadata in the state_dict. This change adds this logic to theget_extra_statemethod ofBasicOperation.