Skip to content

Conversation

@Oleg-Goncharov
Copy link
Collaborator

@Oleg-Goncharov Oleg-Goncharov commented Oct 30, 2025

Description

Deleted unused header file left from the PR#2248.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Goncharov <[email protected]>
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

/te-ci

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR removes the unused header file transformer_engine/common/util/nvfp4_transpose.cuh that was left behind from PR #2248.

  • PR #2248 refactored the cast/gated kernels by splitting them into smaller headers organized by scaling mode
  • The functionality from nvfp4_transpose.cuh was moved to transformer_engine/common/cast/nvfp4/quantize_transpose_nvfp4.cuh during that refactoring
  • The old header file was accidentally not deleted and remained in the codebase
  • No files in the current codebase reference nvfp4_transpose.cuh
  • This is a clean removal with no impact on functionality

Confidence Score: 5/5

  • This PR is safe to merge with zero risk
  • This is a simple cleanup PR that removes an unused header file. The file has no references in the codebase, and its functionality was already migrated to a new location in PR #2248. The deletion has no functional impact.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
transformer_engine/common/util/nvfp4_transpose.cuh 5/5 Deleted unused header file left behind from PR #2248 refactoring - no references found in codebase

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PR as PR #2324
    participant Repo as Repository
    participant Old as nvfp4_transpose.cuh
    participant New as quantize_transpose_nvfp4.cuh

    Note over Dev,New: Context: PR #2248 refactored cast kernels
    Dev->>PR: Delete unused header
    PR->>Old: Remove nvfp4_transpose.cuh
    Note over Old: File was left behind from PR #2248
    Note over New: Functionality already in new location
    Old--xRepo: File deleted
    Note over Repo: No references to old file exist
    Note over Repo: Clean removal, zero impact
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptrendx ptrendx merged commit e7227af into NVIDIA:main Oct 31, 2025
41 checks passed
pggPL pushed a commit to pggPL/TransformerEngine that referenced this pull request Nov 4, 2025
Deleted unused header

Signed-off-by: Oleg Goncharov <[email protected]>
pggPL pushed a commit to pggPL/TransformerEngine that referenced this pull request Nov 6, 2025
Deleted unused header

Signed-off-by: Oleg Goncharov <[email protected]>
wdykas pushed a commit to wdykas/TransformerEngine that referenced this pull request Nov 12, 2025
Deleted unused header

Signed-off-by: Oleg Goncharov <[email protected]>
Signed-off-by: Peter Dykas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants