-
Notifications
You must be signed in to change notification settings - Fork 541
[Common] Deleted unused header #2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Oleg Goncharov <[email protected]>
ksivaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/te-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR removes the unused header file transformer_engine/common/util/nvfp4_transpose.cuh that was left behind from PR #2248.
- PR #2248 refactored the cast/gated kernels by splitting them into smaller headers organized by scaling mode
- The functionality from
nvfp4_transpose.cuhwas moved totransformer_engine/common/cast/nvfp4/quantize_transpose_nvfp4.cuhduring that refactoring - The old header file was accidentally not deleted and remained in the codebase
- No files in the current codebase reference
nvfp4_transpose.cuh - This is a clean removal with no impact on functionality
Confidence Score: 5/5
- This PR is safe to merge with zero risk
- This is a simple cleanup PR that removes an unused header file. The file has no references in the codebase, and its functionality was already migrated to a new location in PR #2248. The deletion has no functional impact.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| transformer_engine/common/util/nvfp4_transpose.cuh | 5/5 | Deleted unused header file left behind from PR #2248 refactoring - no references found in codebase |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant PR as PR #2324
participant Repo as Repository
participant Old as nvfp4_transpose.cuh
participant New as quantize_transpose_nvfp4.cuh
Note over Dev,New: Context: PR #2248 refactored cast kernels
Dev->>PR: Delete unused header
PR->>Old: Remove nvfp4_transpose.cuh
Note over Old: File was left behind from PR #2248
Note over New: Functionality already in new location
Old--xRepo: File deleted
Note over Repo: No references to old file exist
Note over Repo: Clean removal, zero impact
1 file reviewed, no comments
timmoon10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deleted unused header Signed-off-by: Oleg Goncharov <[email protected]>
Deleted unused header Signed-off-by: Oleg Goncharov <[email protected]>
Deleted unused header Signed-off-by: Oleg Goncharov <[email protected]> Signed-off-by: Peter Dykas <[email protected]>
Description
Deleted unused header file left from the PR#2248.
Type of change
Checklist: