Update _launcher.py to fix vector_add.py #592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
requested changes
Apr 30, 2025
There was a problem hiding this comment.
Thanks for catching this bug @markwhen. The fix is not quite right, though, see below. Also, I am curious if you are using driver <11.8 by any chance? This can be confirmed via nvidia-smi.
@rwgk this seems like an overlook from our earlier refactoring. I suspect our CI did not catch it because we don't have runners with old 11.x driver that could trigger this path.
| @@ -146,6 +146,6 @@ def launch(stream, config, kernel, *kernel_args): | |||
| # TODO: check if config has any unsupported attrs | |||
| handle_return( | |||
| driver.cuLaunchKernel( | |||
| int(kernel._handle), *config.grid, *config.block, config.shmem_size, stream._handle, args_ptr, 0 | |||
| int(kernel._handle), *config.grid, *config.block, config.shmem_size, stream._ctx_handle, args_ptr, 0 | |||
There was a problem hiding this comment.
We need a stream here, not context:
Suggested change
| int(kernel._handle), *config.grid, *config.block, config.shmem_size, stream._ctx_handle, args_ptr, 0 | |
| int(kernel._handle), *config.grid, *config.block, config.shmem_size, stream.handle, args_ptr, 0 |
leofang
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes
Checklist