WIP+WIP: PR #604 + use path_finder in bindings (nvJitLink, nvrtc, nvvm) #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty (see updated README.md).
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 7d8ab70 |
|
…ormat, bandit nosec
…_priority_v2_use_in_bindings
|
/ok to test 44eb27e |
The previous implementation checked result_queue.empty() before calling get(), which introduces a classic race condition: the queue may become non-empty immediately after the check, resulting in missed results or misleading errors. This patch replaces the empty() check with result_queue.get(timeout=1.0), allowing the parent process to robustly wait for results with a bounded delay. Also switches from ctx.SimpleQueue() to ctx.Queue() for compatibility with timeout-based get(), which SimpleQueue does not support on Python ≤3.12. Note: The race condition was discovered by Gemini 2.5
…_priority_v2_use_in_bindings
…ority_last() the default.
…_priority_v2_use_in_bindings
|
/ok to test ad9e994 |
…_priority_v2_use_in_bindings
|
/ok to test edc5b33 |
…returns an incompatible `handle`. Use win32api.LoadLibraryEx() instead to ensure self-consistency.
…_priority_v2_use_in_bindings
|
/ok to test f4225ed |
…od. Move run_python_code_safely.py to test/ directory.
…_priority_v2_use_in_bindings
|
@rwgk can this PR be closed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation is under #614
(I deleted NVIDIA:path_finder_dev before repointing this PR, which auto-closed it.)