Varint readfix r36.4.0 #113
Open
+53
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the write pointer moves to write a new record, it takes care not to straddle erase blocks; when reading back account for this. Fix a memory leak in the NvVarIntLibrary. Bug 4788402 Change-Id: I5ff718c066860ca9f20a7bfa4a006b57405f1911 Signed-off-by: Girish Mahadevan <[email protected]> Reviewed-on: https://git-master.nvidia.com/r/c/tegra/bootloader/uefi/edk2-nvidia/+/3244202 Reviewed-by: svcacv <[email protected]> Reviewed-by: Ashish Singhal <[email protected]> GVS: buildbot_gerritrpt <[email protected]> Reviewed-by: svc-sw-mobile-l4t <[email protected]>
When figuring out the LBA for the current block we accidentally used the partition offset and not the block size. Change-Id: I9d0cb3f38694663b832a3d34bd8dbcf9d73096f2 Signed-off-by: Girish Mahadevan <[email protected]>
|
Hello, when will this be merged? Do you have pre-compiled binaries to install? I am unable to get the firmware building using the docker instructions. |
Contributor
Author
|
Hi
Sorry for the late reply.
There is a new PR #118 off of the
rel-36.4 (it should have all the fixes).
Can you try syncing to the r36.4.3-updates branch and building the optee
image ?
I believe the Developer Guide
<https://developer.nvidia.com/embedded/jetson-linux-r3640> should have
instructions to build the image.
Best Regards
Girish
…On Thu, Jan 16, 2025 at 10:55 AM Alex Klimaj ***@***.***> wrote:
Hello, when will this be merged? Do you have pre-compiled binaries to
install? I am unable to get the firmware building using the docker
instructions.
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBZQE237665DZDCGVABRCD2K7XBTAVCNFSM6AAAAABTZAIXWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGM3DANZTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
We have updated to 36.4.3 and so far have not seen the SPI read issue. |
|
Hi, When will this fix be merged to r36.4.4-updates? Or to main branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to the Variable Store Integrity feature. The fixes are to the way the code handles traversing blocks in the Flash device.
The fixes address boot failures with this crash signature:
ASSERT [FvbNorFlashStandaloneMm] /out/nvidia/optee_ftpm.t234-uefi/StandaloneMmOptee_RELEASE/edk2-nvidia/Silicon/NVIDIA/Drivers/FvbNorFlashDxe/FvbNorFlashStandaloneMm.c(937): ((BOOLEAN)(0==1))