-
Notifications
You must be signed in to change notification settings - Fork 681
feature: deferred loading and requirement pruning #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3000d4c
757e0f3
9310d0a
dac569e
35e93fc
bf7f36b
6a39b0c
56c6182
3657e04
865d604
d61957d
8a7051e
60775f6
31e98d4
75babb7
83f551a
dd51196
b33a46c
de5b3f1
19c31fe
54fabc5
ffac714
97c8160
1d4e69c
6164bc5
85fb7c3
0402116
e287fe9
6339648
76b1774
ca133e4
8e8a5b9
aa7500a
4f2e5ef
69cfef2
a1da5ed
3a8605d
d2d17ad
13974b8
dc83929
d527650
8c46730
06180b6
7c22dea
ce23d70
8ab94bd
bb67a3e
b45ba35
de86505
38e6a15
64399a5
65ac9fe
ea71cea
14b958d
d0c90ea
de28c75
1742f60
c877225
6eede53
2bcca2c
9d57b5c
e195148
f8e8635
246b7dc
b9e3b73
40b6bcc
ae5ad5d
1a57c8e
738e8e8
46e1794
dfbe9ac
35fa3d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,7 @@ jobs: | |
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install --no-cache-dir -r requirements.txt | ||
| pip install --no-cache-dir .[tests] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Either
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||
| python -m pip cache purge | ||
|
|
||
| - name: Restore test cache artifacts | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ class ModelNameMissingError(GarakException): | |
| """A generator requires model_name to be set, but it wasn't""" | ||
|
|
||
|
|
||
| class GarakBackoffTrigger(GarakException): | ||
| class GeneratorBackoffTrigger(GarakException): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why rename this? The original name seems clear enough to me, I there some envisioned case where two layers of backoff would need to differentiate the source?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two reasons:
|
||
| """Thrown when backoff should be triggered""" | ||
|
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think linter will want to have all possible dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated