Skip to content

Conversation

@anushaknvidia
Copy link

This revised GCP parameter configuration resolved the errors I encountered with the initial code settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

@anushaknvidia
Copy link
Author

I have read the DCO Document and I hereby sign the DCO

@anushaknvidia
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Jul 22, 2025
@jmartin-tech
Copy link
Collaborator

Was this tested with project_id set? Service account based auth is no longer a preferred pattern based on google documentation making this somewhat complex to validate.

Looking at the change and the google authentication code I don't see project supported as a positional argument that can be passed to the underlying auth call by Client.from_service_account_json() and I see explicit extraction of it from kwargs in the client code.

@leondz leondz marked this pull request as draft September 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants