Add NULL checks after malloc and improve diagnostic logging in shadow pool functions#2188
Open
Pritiks23 wants to merge 1 commit into
Open
Add NULL checks after malloc and improve diagnostic logging in shadow pool functions#2188Pritiks23 wants to merge 1 commit into
Pritiks23 wants to merge 1 commit into
Conversation
Signed-off-by: Pritika Vipin <65793273+Pritiks23@users.noreply.github.com>
Author
|
@justus-nv New PR to dev branch |
Contributor
|
/mirror dev |
justus-nv
reviewed
May 29, 2026
Comment on lines
-14
to
-15
| NCCL_PARAM(ShadowMempoolMaxSize, "SHADOW_MEMPOOL_MAX_SIZE", 1LL << 30); | ||
|
|
Contributor
There was a problem hiding this comment.
Why was this removed? It seems out of scope.
| props.handleTypes = cudaMemHandleTypeNone; | ||
| props.location.type = cudaMemLocationTypeDevice; | ||
| cudaGetDevice(&props.location.id); | ||
| props.maxSize = (size_t)ncclParamShadowMempoolMaxSize(); |
Contributor
There was a problem hiding this comment.
Same here? Why was this removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR targets
devand carries the latest branch state fromPritiks23:combine-prs, rebased to latestupstream/devand containing only the allocator hardening change insrc/allocator.cc.Changes included:
ncclShadowPoolAllocncclShadowPoolFreeThis is opened in addition to #2175 (left open as requested).
Signed-off-by: Pritika Vipin 65793273+Pritiks23@users.noreply.github.com