-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Decouple Orchestration and API Layers in NV-Ingest #485
Open
drobison00
wants to merge
92
commits into
NVIDIA:main
Choose a base branch
from
drobison00:devin_fea_pythonic_refactor_part0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor: Decouple Orchestration and API Layers in NV-Ingest #485
drobison00
wants to merge
92
commits into
NVIDIA:main
from
drobison00:devin_fea_pythonic_refactor_part0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion' into devin_fea_icm_conversion
…ractor to unified API interface
… copy of the client impls and response types exists now
…ion. Various quality of life fixes
3 tasks
updates to make audio extraction work
…refactor_part0' into devin_fea_pythonic_refactor_part0
updates to make nemoretriever-parse work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
epic
high level feature/functionality
feature request
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors
nv-ingest
to cleanly separate the orchestration layer from the API elements, allowing finer-grained usage of individual work elements via the API. This improves modularity and makes it easier to invoke specific pipeline components independently.Changes
Separation of Concerns
src/api/
to centralize API functionality.src/nv_ingest/framework/
, ensuring a clearer distinction between execution flow and API access.client/
.Standardized API Interface
Benefits
Next Steps
Checklist