MSC Checkpointing Changes #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysubr
reviewed
Feb 20, 2025
akshaysubr
reviewed
Mar 11, 2025
akshaysubr
reviewed
Mar 11, 2025
akshaysubr
reviewed
Mar 11, 2025
Fix merge conflicts
Signed-off-by: Chris Hawes <[email protected]>
|
/blossom-ci |
|
/blossom-ci |
|
/blossom-ci |
|
/blossom-ci |
2 similar comments
|
/blossom-ci |
|
/blossom-ci |
|
/blossom-ci |
|
/blossom-ci |
2 similar comments
|
/blossom-ci |
|
/blossom-ci |
|
/blossom-ci |
RishikeshRanade
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Working changes to be cleaned up. * Rename msc_config.yaml * Fixed pytorch test issue by removing MSC Cache * Updated project dependencies * Find MSC config using absolute path. * Re-added cuda test parameter. * Add test to read from public S3 bucket using MSC. * Revert save_checkpoint_freq value. * Remove temporary printing * Remove unnecessary dependency * Switched to use consistent mechanism for detecting msc URIs * Moved fsspec.filesystem logic into filesystem.py * Change to cache for non-file protocols when reading non-modulus models. * Moved code to generate checkpoint directory.directory * Added get_checkpoint_dir import * Address review feedback. * Changes from code review. * Addressed file test issue from review. * Fix to file existence check. * Fix merge conflicts due to project name change. * Updated CHANGELOG. * Added Multi-Storage Client to allow checkpointing to/from Object Storage Signed-off-by: Chris Hawes <[email protected]> * Addressed issues identified by pre-commit. * Update filesystem.py * Update __init__.py * Update Dockerfile --------- Signed-off-by: Chris Hawes <[email protected]> Co-authored-by: Nicholas Geneva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
Checklist
Dependencies